Skip to content

GH-50849: [Python] Return correct ParquetLogicalType.type for geometry/geography - #50850

Merged
raulcd merged 2 commits into
apache:mainfrom
jorisvandenbossche:gh-50849-parquet-geometry-type
Aug 13, 2026
Merged

GH-50849: [Python] Return correct ParquetLogicalType.type for geometry/geography#50850
raulcd merged 2 commits into
apache:mainfrom
jorisvandenbossche:gh-50849-parquet-geometry-type

Conversation

@jorisvandenbossche

@jorisvandenbossche jorisvandenbossche commented Aug 11, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Fix the return value of ParquetLogicalType.type for geometry/geography types

Are these changes tested?

Yes

Are there any user-facing changes?

Not apart from the bug fix

Copilot AI lite review requested due to automatic review settings August 11, 2026 13:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the Python Parquet metadata binding so ParquetLogicalType.type returns the correct string for the GEOMETRY/GEOGRAPHY logical types, matching the underlying Parquet logical type enum.

Changes:

  • Extend the logical type enum-to-name mapping to include GEOMETRY and GEOGRAPHY.
  • Add a regression test that reads geospatial Parquet fixtures and asserts the logical type name and geo statistics accessors.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
python/pyarrow/_parquet.pyx Adds GEOMETRY/GEOGRAPHY to the enum name mapping used by ParquetLogicalType.type.
python/pyarrow/tests/parquet/test_metadata.py Adds regression coverage for geometry/geography logical types and geo statistics.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread python/pyarrow/_parquet.pyx Outdated
Copilot AI review requested due to automatic review settings August 11, 2026 13:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@github-actions github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Aug 13, 2026
@raulcd
raulcd merged commit 1b004f2 into apache:main Aug 13, 2026
39 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Aug 13, 2026
@jorisvandenbossche
jorisvandenbossche deleted the gh-50849-parquet-geometry-type branch August 13, 2026 08:56
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1b004f2.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants