GH-1228: Arrow Format 1.5: Decimal32/Decimal64 support#1227
Open
robert3005 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
robert3005
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
robert3005
changed the title
This comment has been minimized.
This comment has been minimized.
Author
|
I don't think I am allowed to add labels, but this should be an 'enhancement' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Add support arrow format spec 1.5. We were missing Decimal32/64 in arrow-java which were added to the spec on Sep 10, 2024. The code is mostly analogous to other two decimal types. The one thing that I didn't want to break is to not rename DecimalArray to Decimal128Array, therefore the other 3 arrays have width in their name while 128 does not.
This pr was authored with help of Claude Fable 5
closes #1228