Skip to content

fix(template): show tag display names instead of their slugs #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
culfin wants to merge 1 commit into from
+5 −5
Closed

fix(template): show tag display names instead of their slugs #1586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/template/question-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ <h1 class="h3 mb-3 text-wrap text-break">
{{range .detail.Tags}}
<a href="{{$.baseURL}}/tags/{{.SlugName}}"
class="badge-tag rounded-1 {{if .Reserved}}badge-tag-reserved{{end}} {{if .Recommend}}badge-tag-required{{end}} m-1">
<span class="">{{.SlugName}}</span>
<span class="">{{.DisplayName}}</span>
</a>
{{end}}
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/template/question.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ <h5 class="text-wrap text-break">
<a
href="{{$.baseURL}}/tags/{{.SlugName}}"
class="badge-tag rounded-1 {{if .Reserved}}badge-tag-reserved{{end}} {{if .Recommend}}badge-tag-required{{end}} me-1">
<span class="">{{.SlugName}}</span>
<span class="">{{.DisplayName}}</span>
</a>
{{end}}
</div>
Expand Down
4 changes: 2 additions & 2 deletions ui/template/tag-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<div class="page-main flex-auto col">
<div class="tag-box mb-5">
<h3 class="mb-3">
<a class="link-dark" href="{{$.baseURL}}/tags/{{$.tag.SlugName}}">{{$.tag.SlugName}}</a>
<a class="link-dark" href="{{$.baseURL}}/tags/{{$.tag.SlugName}}">{{$.tag.DisplayName}}</a>
</h3>
<p class="text-break">{{formatLinkNofollow $.tag.ParsedText}}</p>
</div>
Expand Down Expand Up @@ -80,7 +80,7 @@ <h5 class="text-wrap text-break">
{{range .Tags }}
<a href="{{$.baseURL}}/tags/{{.SlugName}}"
class="badge-tag rounded-1 {{if .Reserved}}badge-tag-reserved{{end}} {{if .Recommend}}badge-tag-required{{end}} m-1">
<span class="">{{.SlugName}}</span>
<span class="">{{.DisplayName}}</span>
</a>
{{end}}
</div>
Expand Down
2 changes: 1 addition & 1 deletion ui/template/tags.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ <h3 class="mb-4">
<div class="h-100 card">
<div class="d-flex flex-column align-items-start card-body">
<a href="{{$.baseURL}}/tags/{{.SlugName}}" class="badge-tag rounded-1 mb-3"><span
class="">{{.SlugName}}</span></a>
class="">{{.DisplayName}}</span></a>
<div class="small flex-fill text-break text-wrap text-truncate-3 reset-p mb-3"> {{formatLinkNofollow .ParsedText}}
</div>
<div class="d-flex align-items-center">
Expand Down