Skip to content

Fix dark theme incomplete rendering by adding runtime theme algorithm#11642

Open
Claude wants to merge 8 commits intomasterfrom
claude/fix-dark-theme-bug
Open

Fix dark theme incomplete rendering by adding runtime theme algorithm#11642
Claude wants to merge 8 commits intomasterfrom
claude/fix-dark-theme-bug

Conversation

@Claude
Copy link
Copy Markdown

@Claude Claude AI commented Apr 3, 2026

  • Fix TypeScript compilation errors in antd runtime config
  • Update Jest snapshots to match code changes

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages bot commented Apr 3, 2026

Deploying ant-design-pro with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: 66003c5
Status:Β βœ…Β  Deploy successful!
Preview URL: https://93ffed34.ant-design-pro-nd3.pages.dev
Branch Preview URL: https://claude-fix-dark-theme-bug.ant-design-pro-nd3.pages.dev

View logs

- Add RuntimeAntdConfig export in app.tsx that dynamically applies theme.darkAlgorithm when navTheme is 'realDark'
- Remove static theme config from config.ts to allow runtime configuration
- This ensures the entire app (including backgrounds) properly switches to dark theme

Agent-Logs-Url: https://github.com/ant-design/ant-design-pro/sessions/3968532c-b6fa-45bb-bf32-ae47ab93c36c

Co-authored-by: afc163 <507615+afc163@users.noreply.github.com>
@Claude Claude AI changed the title [WIP] Fix bug when switching to dark theme Fix dark theme incomplete rendering by adding runtime theme algorithm Apr 3, 2026
@Claude Claude AI requested a review from afc163 April 3, 2026 07:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

😭 Deploy PR Preview failed.

Add proper type annotation for memo parameter to resolve TS2339 error

Agent-Logs-Url: https://github.com/ant-design/ant-design-pro/sessions/06d932cc-9f2c-486d-bb75-564b647eb633

Co-authored-by: afc163 <507615+afc163@users.noreply.github.com>
Fixed TypeScript error TS2322 by making initialState property optional.
The framework may call the antd runtime config function with an empty
object, so initialState cannot be required.

πŸ€– Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Co-authored-by: afc163 <507615+afc163@users.noreply.github.com>
@afc163 afc163 marked this pull request as ready for review April 3, 2026 11:47
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
βœ… Project coverage is 39.14%. Comparing base (87f8528) to head (66003c5).

Files with missing lines Patch % Lines
src/app.tsx 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11642      +/-   ##
==========================================
- Coverage   39.70%   39.14%   -0.56%     
==========================================
  Files         196      196              
  Lines        2340     2345       +5     
  Branches      392      405      +13     
==========================================
- Hits          929      918      -11     
- Misses       1411     1423      +12     
- Partials        0        4       +4     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› [BUG] εˆ‡ζ’εˆ°ζš—ι»‘δΈ»ι’˜ ζœ‰bug

2 participants