test(codemode): widen the test262 baseline to all implemented built-ins and expressions - #48511
Closed
rekram1-node wants to merge 1 commit into
Closed
test(codemode): widen the test262 baseline to all implemented built-ins and expressions#48511rekram1-node wants to merge 1 commit into
rekram1-node wants to merge 1 commit into
Conversation
…ns and expressions
Collaborator
Author
|
Keeping the widened baseline local until the rewrite; the test262 files don't run in CI, so this adds lines without changing what CI checks. The rewrite branches will base off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #48446. Manifest-only widening of the test262 baseline before the interpreter rewrite, so regressions anywhere in the object model are visible.
Changes
manifest.json— directories now cover every built-in the interpreter implements (Array,Object,JSON,String,Number,Math,Boolean,Date,Map,Set,Promise,RegExp,Error/NativeErrors/AggregateError, the global functions and constants) pluslanguage/expressionsalongsidelanguage/statements. The boxed-primitive boundary also matchesObject(<primitive>).skipped.txt— regenerated: 2093 known gaps with reasons.interpreter-support.md— new[ ]items for gap categories the wider run exposed: ToPrimitive on object operands, ToPropertyKey coercion,IteratorCloseresult validation,String.raw, string-method argument coercion, Date argument coercion; generator (not only async generator) parameter timing;propertyIsEnumerable.run.ts— names program functions in harness messages.Results at the pinned revision
10311 files synced, 8218 pass, 2093 skipped, 0 fail; ~6 s for the full set. Files remain gitignored and are populated locally via
script/sync-test262.ts; CI is unchanged.Pass rate by area: Math 93%, Number 88%, Date 87%, JSON 86%, Set 86%, Promise 85%, statements 81%, Array 79%, expressions 79%, String 74%, RegExp 71%, Map 64%, Object 61%, Error 0% (all 15 use ToPrimitive on the message).
Largest gaps: function
name/length(414), non-index array properties (277), interpreter errors typedErrorinstead ofTypeError/RangeError/ReferenceError(152+), generator parameter evaluation timing (~200),const { constructor } = err(154), operators on non-data values (70).