fix: live-refresh desktop file panel on disk changes - #48448
Open
acehighdan wants to merge 2 commits into
Open
acehighdan wants to merge 2 commits into
acehighdan wants to merge 2 commits into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48451
Type of change
What does this PR do?
The desktop "All files" panel did not live-refresh on disk changes made outside the agent Write tool: created files appeared only after an unrelated refresh, and deleted files never disappeared.
Root cause: the filesystem watcher is location-scoped. When a session directory is invalidated, its inotify subscription is torn down and nothing re-subscribes it, so the panel stops receiving change events.
Fix, two parts:
packages/core: watch the workspace directory unconditionally instead of gating it behind the experimental flag + VCS check, so non-git roots get live events too.packages/app: while the window is visible, poll every expanded/loaded directory every 5s when watcher events are absent.FileSystem.listis cacheless and error toasts are suppressed for polled directories. Watcher events remain the fast path.How did you verify your code works?
bun typecheckclean and 45 file-context unit tests pass inpackages/app.touchandrmnow appear/disappear in the panel within one poll cycle.Screenshots / recordings
n/a (behavior change, verified live rather than visual)
Checklist