Skip to content

fix(core): omit undefined permission metadata - #48443

Closed
S1LentH3arT wants to merge 1 commit into
anomalyco:devfrom
S1LentH3arT:permission-metadata
Closed

fix(core): omit undefined permission metadata#48443
S1LentH3arT wants to merge 1 commit into
anomalyco:devfrom
S1LentH3arT:permission-metadata

Conversation

@S1LentH3arT

Copy link
Copy Markdown

Summary

  • omit undefined fields when storing permission metadata
  • preserve false, zero, and null metadata values

Tests

  • bun turbo typecheck --concurrency=2
  • bun test test/permission.test.ts (packages/core)

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Sep 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Found related PRs that address similar issues:

Potential Duplicates:

  1. PR fix(core): drop undefined metadata values from permission requests #46964 - fix(core): drop undefined metadata values from permission requests

  2. PR fix(core): drop undefined permission metadata values before publishing requests #46906 - fix(core): drop undefined permission metadata values before publishing requests

These two earlier PRs appear to target the same issue. You should verify whether they were merged or closed, and if so, whether this PR (48443) addresses the same problem in a different way or if it's addressing a regression/oversight from those attempts.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 11, 2026
@github-actions github-actions Bot closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant