refactor(tui): project production subgroups through tree engine - #48399
Conversation
e2f2823 to
2ab7bff
Compare
|
Drive comparison completed: 201/201 full-screen screenshot pairs are pixel-identical with matching settings between installed OpenCode Coverage: 14 fixed imported fixtures; 80/112/160 columns; top/bottom navigation including paginated histories; grouped/collapsed and ungrouped/expanded settings; manual thought/exploration disclosure open/close checks. Compared full RGBA images without masks or tolerances. The development-only DevTools bar was disabled identically on both sides to match viewport geometry. A clean latest-v2 source comparison was also run. One separate parity blocker remains: independently reproduced the Sol review finding that pending filtering by Local report and reproducible scripts: |
|
Follow-up: reproduced the permission identity regression through the real TUI app and client event pipeline, using a controlled HTTP/SSE replay. The same screen assertion passes on production v2 and fails on this PR: production renders “Exploring — 1 read” and can reveal This requires separate live event phases; full hydration/coalesced delivery can mask it. Natural model-run reachability of this ordering is not established. Four nearby real-TUI controls passed on both builds (distinct IDs, permission resolved first, replayed admission, two pending permissions), with 16/16 pixel-identical stage pairs. A seeded 3000-history / 150000-transition comparison found no additional mismatch beyond this same bug. Screenshots saved under |
|
Fixed the pending-reference regression in Verification after the fix:
Fixed screenshot: |
Base
Rebased onto the latest
v2after #48394 merged. The diff contains only the production integration. Post-rebase TUI typecheck and 29 grouping/session-row tests pass.Summary
This increment preserves default grouping membership, labels, loading state, disclosure behavior and navigation. Nested experimental rules, boundary-completing pagination and leaf-based mounting follow separately. The renderer consumes subgroup refs from the tree; there is no separate flat timeline projection.
Verification
--devreplay: busy/completed states, failed and successful reads, thought/exploration disclosures, narrow layout, last-user navigation; compared expanded layouts with the original extraction worktreeLarge diagnostic suites, screenshots and the work log remain local as requested. A separate Sol review session will review this increment before merge.