fix: use distinct sidebar icon for mobile sidebar toggle to avoid duplicate icon with WindowsAppMenu#31114
Open
cmw-creator wants to merge 1 commit into
Open
Conversation
…th WindowsAppMenu
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31115
Type of change
What does this PR do?
On Windows/Linux, when the window is narrowed below the xl breakpoint, the WindowsAppMenu button (opening the application menu) and the mobile sidebar toggle button (toggling the sidebar) both show a
menu(hamburger) icon. These are two different buttons with different functions but identical icons.At full screen (xl+), the mobile sidebar toggle is hidden via
xl:hidden, so only the WindowsAppMenu's hamburger icon is visible — no conflict. When the window narrows to < xl, the mobile sidebar toggle becomes visible and both buttons show the same icon.The fix changes the mobile sidebar toggle's icon from
"menu"to"sidebar"(a layout/panel icon), which matches the desktop sidebar toggle's icon used at larger breakpoints. This makes the two buttons visually distinguishable.How did you verify your code works?
Verified the icon name
sidebarexists in the legacy icon set (packages/ui/src/components/icon.tsxline 60). The desktop sidebar toggle (line 576) already uses this same icon name successfully. Only icon name changed; no structural or behavioral changes.Screenshots / recordings
N/A — unable to capture the opencode UI in my environment, but the fix is a two-character icon name change with no logic modification.
Checklist