fix(core): allow colons inside passwords#29576
Merged
kitlangton merged 4 commits intoMay 28, 2026
Merged
Conversation
Contributor
|
Verified locally with |
kitlangton
approved these changes
May 28, 2026
Contributor
kitlangton
left a comment
kitlangton
left a comment
There was a problem hiding this comment.
Verified locally and the decoder change matches HTTP Basic credential semantics. The regression test covers the reported failure path.
Contributor
Author
|
Seems like the CI got stuck |
tranngoclai
pushed a commit
to tranngoclai/opencode
that referenced
this pull request
May 30, 2026
Co-authored-by: Kit Langton <kit.langton@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29575
Type of change
What does this PR do?
The colon
:wasn't allowed inside passwords due to how it was splitting by:If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Try to auth with a password containing a colon
:Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.