fix(desktop): correct user code extraction when URL contains colons#28837
Merged
Conversation
rustybret
pushed a commit
to rustybret/opencode
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #28834
Type of change
What does this PR do?
Fixed user code extraction in the desktop app's OAuth auto-view. The previous code used
instructions.split(":")[1]?.trim(), which breaks when the instruction text contains multiple colons (e.g., xAI's Open https://accounts.x.ai/oauth2/device on any device and enter code: ABCD-1234). This caused garbled text like "//accounts.x.ai/oauth2/device on any device and enter code" to display instead of the actual code.Changed to
instructions.split(":").pop()?.trim()to always grab the final segment (the real user code) regardless of how many colons appear in the URL or instruction text.How did you verify your code works?
Screenshots / recordings
Checklist