fix(share): show session turn labels in desktop MessageNav#27960
Closed
Arcadi4 wants to merge 1 commit into
Closed
fix(share): show session turn labels in desktop MessageNav#27960Arcadi4 wants to merge 1 commit into
Arcadi4 wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
The share page was using size=compact MessageNav which renders invisible tick lines. Switch to size=normal to show message summary titles and diff bars, making turn navigation discoverable without tooltip hovering.
Arcadi4
force-pushed
the
fix/share-page-message-nav-labels
branch
from
078e919 to
838480d
Compare
github-actions
Bot
removed
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Author
|
#23964 likely provides a better fix. Please consider merging it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23958
Type of change
What does this PR do?
The desktop share page uses
size="compact"for MessageNav, which renders invisible tick marks instead of readable turn labels. Users can't discover navigation and only see the first turn. Switching tosize="normal"shows diff bars and message titles (240px wide) — the CSS and component already support both sizes.How did you verify your code works?
md:flex/lg:flexbreakpoints (desktop layout only)turns()— unaffected[data-size="normal"]already exists inmessage-nav.csslsp_diagnosticsclean on the changed fileScreenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist