fix(web): route zht locale to Discord instead of Feishu#27640
Open
TsurumaruTsuyoshi wants to merge 1 commit into
Open
fix(web): route zht locale to Discord instead of Feishu#27640TsurumaruTsuyoshi wants to merge 1 commit into
TsurumaruTsuyoshi wants to merge 1 commit into
Conversation
PR anomalyco#16908 routed both `zh` and `zht` locales to a Feishu group. Feishu is primarily used inside mainland China; Traditional Chinese readers in Hong Kong, Taiwan, Macau, and overseas communities largely do not have Feishu accounts and cannot join via the applink without one. This commit keeps Feishu for `zh` (Simplified Chinese) but routes the `zht` locale back to the existing Discord community: - `footer.tsx`: narrow the Feishu branch to `locale === "zh"` - `README.zht.md`: restore the Discord link - `i18n/zht.ts`: drop the now-unused `footer.feishu` entry
github-actions
Bot
added
the
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
added
needs:issue
and removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #27642.
Type of change
What does this PR do?
#16908 routed both
zhandzhtlocales to a Feishu group. The Traditional Chinese (zht) audience is primarily in Hong Kong, Taiwan, Macau, and overseas communities, where Feishu has very little reach. A few practical barriers to joining via Feishu for that audience:This PR keeps Feishu for
zh(Simplified Chinese) — respecting the intent of #16908 for that audience — and routeszhtback to the existing Discord community:packages/console/app/src/component/footer.tsx: narrow the Feishu branch fromlocale === "zh" || locale === "zht"tolocale === "zh".README.zht.md: restore the Discord link in the community footer.packages/console/app/src/i18n/zht.ts: correct thefooter.feishutranslation from the Simplified form飞书to the Traditional form飛書. The key is kept (matchingen.ts, which also retains it for dictionary completeness) even though thezhtlocale no longer references it from the footer.No changes to the
zhlocale, theendict, or the/feishuredirect route.How did you verify your code works?
language.locale()returns"zht"for Traditional Chinese visitors, which now falls through to the Discord branch infooter.tsx.footer.feishu— only thezhandendicts remain, both intentional.Screenshots / recordings
Text/link-only change.
Checklist
If you do not follow this template your PR will be automatically rejected.