fix(opencode): run transformParams middleware unconditionally for all call types#19558
Closed
robinmordasiewicz wants to merge 1 commit into
Closed
fix(opencode): run transformParams middleware unconditionally for all call types#19558robinmordasiewicz wants to merge 1 commit into
robinmordasiewicz wants to merge 1 commit into
Conversation
… call types The `if (args.type === "stream")` guard meant non-stream call types skipped ProviderTransform.message() entirely — no normalizeMessages(), no applyCaching(), no tool-call ID scrubbing. The prompt shape is the same regardless of call type. Fixes anomalyco#19557
6 tasks
Collaborator
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #19557
Type of change
What does this PR do?
The
transformParamsmiddleware inllm.tswrapsProviderTransform.message()behind anif (args.type === "stream")guard. Non-stream call types skip the entire normalization pipeline —normalizeMessages(),applyCaching(), and tool-call ID scrubbing all get bypassed.The prompt shape is the same regardless of
args.type, so the guard has no purpose. This removes it so the middleware runs unconditionally. The existing TODO comment on the line suggests this was already known to be questionable.How did you verify your code works?
bun turbo typecheck)ProviderTransform.message()is called for both stream and non-stream paths by adding a temporary log and runningbun devChecklist