Skip to content

fix: fix OAuth PKCE verifier overwrite and transport authProvider lookup#19280

Closed
Vishal2002 wants to merge 2 commits into
anomalyco:devfrom
Vishal2002:fix/mcp-oauth-nonstandard-error-response
Closed

fix: fix OAuth PKCE verifier overwrite and transport authProvider lookup#19280
Vishal2002 wants to merge 2 commits into
anomalyco:devfrom
Vishal2002:fix/mcp-oauth-nonstandard-error-response

Conversation

@Vishal2002
Copy link
Copy Markdown

@Vishal2002 Vishal2002 commented Mar 26, 2026

Issue for this PR

Closes #17822

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fixes an issue where OAuth remained stuck in needs_auth after a successful login.

  • Prevent duplicate saveCodeVerifier calls causing invalid_grant
  • Fix incorrect authProvider access (_authProvider)
  • Ensure transport is stored after redirect regardless of error type
  • Add support for non-standard OAuth error responses

How did you verify your code works?

Tested locally with Notion MCP and Atlassian MCP.
OAuth flow completes successfully, tokens persist, and client is reused across runs.

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Found one potentially related PR:

PR #18674 - "fix: vendor Anthropic OAuth plugin and fix PKCE state security issue (fixes #18652)"
#18674

This PR also addresses PKCE-related security issues in the OAuth flow, though it focuses on a different issue (#18652 vs #17822). Both PRs involve OAuth PKCE fixes, so there's a chance of overlap in the areas being modified.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@Vishal2002 Vishal2002 force-pushed the fix/mcp-oauth-nonstandard-error-response branch from 0ad3cbf to 8e0a0d7 Compare March 26, 2026 13:02
@rekram1-node
Copy link
Copy Markdown
Collaborator

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote MCP OAuth: token immediately overwritten after successful browser callback

2 participants