feat(cli): add ACP attach support#18272
Closed
shekohex wants to merge 2 commits into
Closed
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found a potentially related PR: #12743 - "feat(opencode): add backend server selection options for acp mode" This PR appears to address similar functionality around allowing ACP to connect to backend servers instead of always starting locally, which is closely related to the However, PR #12743 appears to be from an earlier iteration or different approach. You may want to review it to ensure there's no overlapping implementation or if it was previously closed/superseded. |
553134a to
c81cde0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #12853
Type of change
What does this PR do?
Adds
--attachtoopencode acpso ACP can bridge stdio to an existingopencode servebackend instead of always starting a local server.It keeps the current local startup path unchanged, forwards
--cwdin both modes, and updates the ACP/CLI docs plus the localized ACP/CLI pages.How did you verify your code works?
bun typecheckprintf '%s\\n' '{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"initialize\",\"params\":{\"protocolVersion\":1}}' | bun run ./src/index.ts acpprintf '%s\\n' '{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"initialize\",\"params\":{\"protocolVersion\":1}}' | bun run ./src/index.ts acp --attach http://127.0.0.1:4105withbun run ./src/index.ts serve --port 4105Screenshots / recordings
N/A
Checklist