fix(core): fix #969, should be able to access target/eventName info in onScheduleTask#972
Conversation
| const data = useGlobalCallback ? OPTIMIZED_ZONE_EVENT_TASK_DATA : null; | ||
|
|
||
| // keep taskData into data to allow onScheduleEventTask to acess the task information | ||
| (data as any).taskData = taskData; |
There was a problem hiding this comment.
if the useGlobalCallback is false, data would be null and this line would fail.
There was a problem hiding this comment.
@jahtalab, yes, you are right, thank you.
|
Is |
|
@jahtalab , it is |
|
Thanks @JiaLiPassion , |
|
@jahtalab, you are welcome and I am not sure the release date. |
|
Tests are failing because of rxjs changes in exposed API in the newer versions. I had to lock rxjs version to |
|
@jahtalab , yes, this is a known issue, the other PR has used the |
… info when onScheduleTask
fix #969.
Should be able to access
target/eventName/captureinformation when usingaddEventListenerinonScheduleTaskcallback.in
onScheduleTask.in
onInvokeTask,onCancelTask.it is not consistent because of
performanceconcern (don't want to create so many object).