This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(mocha): use global if window does not exist#943
Merged
mhevery merged 1 commit intoangular:masterfrom Dec 27, 2017
justindujardin:mocha-nativescript
Merged
fix(mocha): use global if window does not exist#943mhevery merged 1 commit intoangular:masterfrom justindujardin:mocha-nativescript
mhevery merged 1 commit intoangular:masterfrom
justindujardin:mocha-nativescript
Conversation
| })(Mocha.Runner.prototype.runTest, Mocha.Runner.prototype.run); | ||
|
|
||
| })(window); No newline at end of file | ||
| })(typeof window !== 'undefined' ? window : global); |
Collaborator
There was a problem hiding this comment.
please use
})(typeof window !== 'undefined' && window || typeof self !== 'undefined' && self || global);which is used here https://github.com/angular/zone.js/blob/master/lib/zone.ts#L1344
- `window` does not exist in NativeScript applications. - this removes a hacky workaround where you assign `global.window` to `global` before including the mocha patch. - preserve existing behavior by using window first if it exists.
Contributor
Author
|
The CI build appears to be broken unrelated to this change. System.js is failing to import some rxjs operators. |
Collaborator
|
@justindujardin , yes, current CI is broken, you can just ignore that. |
mhevery
approved these changes
Dec 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
windowdoes not exist in NativeScript applications.global.windowtoglobalbefore including the mocha patch.