This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(core): fix #405, refine the error message when zone.js already loaded#728
Merged
Conversation
mhevery
approved these changes
Apr 10, 2017
Contributor
|
@JiaLiPassion Sorry I had to revert this one as it broke the build. Can you reopen this as a new PR? |
Collaborator
Author
|
@mhevery,got it,I will make a new PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #405.
We often see that 'Zone.js already loaded' error, when we wrongly load zone.js twice, or load zone.js in some polyfill by incidentally.
In this PR, we will try to throw the error message as
So it will be easy to find out what is wrong, but it require the both zone.js to be upgrade to newer version (maybe 0.8.6)