Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Don't patch itself recursively#467

Closed
Freak613 wants to merge 1 commit intoangular:masterfrom
Freak613:patch-1
Closed

Don't patch itself recursively#467
Freak613 wants to merge 1 commit intoangular:masterfrom
Freak613:patch-1

Conversation

@Freak613
Copy link
Copy Markdown

I'm using fetch polyfill (https://github.com/camsong/fetch-ie8).
I'm loading this polyfill before zone.js loading, to get fetch patched by zone.

In this block fetch has been called to patch its returning Promise realization.
It happens, that at the moment of the call, global Promise already has been patched by Zone, fetch returns ZoneAwarePromise as a result, and then zone patch its own promise which leads to recursive calls on the first attempt of using fetch.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Freak613
Copy link
Copy Markdown
Author

I signed it! lol

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Oct 1, 2016

Duplicate of #451

@mhevery mhevery closed this Oct 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants