Repository navigation
Conversation
PR angular#30866 removed the obsolete caretaker resync script, but left its npm command and direct @octokit/rest dependency behind. Remove those remaining entries and update the root lockfile importer. Keep the transitive @octokit/rest dependency required by @angular/ng-dev.
crisbeto
approved these changes
Nov 4, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete the cleanup from #30866, which removed the obsolete
scripts/caretaking/resync-caretaker-app-prs.tsscript in commit 912bacd.The script itself was removed, but its
resync-caretaker-appnpm command and direct@octokit/restdevelopment dependency were left in the rootpackage.json. The command points to a file that no longer exists, and there are no remaining repository source or configuration references to@octokit/rest.Remove the stale command, the unused direct dependency, and its root lockfile importer entry. Retain the transitive
@octokit/restpackage required by@angular/ng-dev; this change does not claim to eliminate it from the full dependency tree. No published Material/CDK package or component behavior changes.Validation
pnpm install --frozen-lockfile --config.engine-strict=falsepassed (Node.js 24.22.2, pnpm 12.16.1; the repository already setsengineStrict: false).pnpm check-tooling-setuppassed for tools, API extraction tooling, scripts, and.ng-devconfiguration.pnpm ng-dev pullapprove verifypassed.pnpm bazelisk test //tools/markdown-to-html:unit_testspassed: 9 specs, 0 failures.git diff --checkpassed.node_modules/@octokit/restlink is absent while resolution from@angular/ng-devstill succeeds.The full Material/CDK component and browser suites were not run locally for this repository tooling cleanup.