Skip to content

build: remove leftover caretaker script configuration - #34054

Merged
crisbeto merged 1 commit into
angular:mainfrom
nagahara-naoki:remove-obsolete-caretaker-script-config
Nov 4, 2026
Merged

crisbeto merged 1 commit into
angular:mainfrom
nagahara-naoki:remove-obsolete-caretaker-script-config

Conversation

@nagahara-naoki

Copy link
Copy Markdown
Contributor

Summary

Complete the cleanup from #30866, which removed the obsolete scripts/caretaking/resync-caretaker-app-prs.ts script in commit 912bacd.

The script itself was removed, but its resync-caretaker-app npm command and direct @octokit/rest development dependency were left in the root package.json. The command points to a file that no longer exists, and there are no remaining repository source or configuration references to @octokit/rest.

Remove the stale command, the unused direct dependency, and its root lockfile importer entry. Retain the transitive @octokit/rest package required by @angular/ng-dev; this change does not claim to eliminate it from the full dependency tree. No published Material/CDK package or component behavior changes.

Validation

  • pnpm install --frozen-lockfile --config.engine-strict=false passed (Node.js 24.22.2, pnpm 12.16.1; the repository already sets engineStrict: false).
  • pnpm check-tooling-setup passed for tools, API extraction tooling, scripts, and .ng-dev configuration.
  • pnpm ng-dev pullapprove verify passed.
  • pnpm bazelisk test //tools/markdown-to-html:unit_tests passed: 9 specs, 0 failures.
  • Prettier and git diff --check passed.
  • Confirmed the root node_modules/@octokit/rest link is absent while resolution from @angular/ng-dev still succeeds.

The full Material/CDK component and browser suites were not run locally for this repository tooling cleanup.

PR angular#30866 removed the obsolete caretaker resync script, but left its
npm command and direct @octokit/rest dependency behind. Remove those
remaining entries and update the root lockfile importer.

Keep the transitive @octokit/rest dependency required by @angular/ng-dev.
@angular-robot angular-robot Bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 3, 2026
@pullapprove
pullapprove Bot requested review from crisbeto and ok7sai November 3, 2026 12:53
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 4, 2026
@crisbeto
crisbeto removed the request for review from ok7sai November 4, 2026 08:37
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 4, 2026
@crisbeto
crisbeto merged commit 46f61fe into angular:main Nov 4, 2026
19 checks passed
@crisbeto

crisbeto commented Nov 4, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants