Repository navigation
Conversation
sdedieu
force-pushed
the
feat/progress-bar-active-indicator-shape
branch
from
October 30, 2026 11:03
b2b4f07 to
fab49ee
Compare
crisbeto
reviewed
Nov 2, 2026
| overflow-x: hidden; | ||
| transition: opacity 250ms 0ms cubic-bezier(0.4, 0, 0.6, 1); | ||
|
|
||
| border-radius: token-utils.slot(progress-bar-active-indicator-shape, $fallbacks); |
Member
There was a problem hiding this comment.
This isn't doing much, because it only applies to the outer container, not the inner elements. Users can already do it by just targeting the host element.
Author
There was a problem hiding this comment.
One alternative could be to have the progress-bar-track-shape also affecting the active-indicator shape (.mdc-linear-progress border-radius). Would it makes more sense ?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #28554