fix(material/icon): keep FuncIRI references on current origin - #33812
Open
moamenmahmod wants to merge 1 commit into
Open
moamenmahmod wants to merge 1 commit into
moamenmahmod wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Paths beginning with two slashes were interpreted as protocol-relative URLs when MatIcon rewrote same-document SVG references. Prefix those paths with a dot segment so they resolve on the current origin while retaining the current document path.
moamenmahmod
force-pushed
the
fix/mat-icon-protocol-relative-funciri
branch
from
September 15, 2026 23:28
ed1f16c to
9860d5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MatIconFuncIRI rewrites on the current origin when the page path starts with//dot segment
Background
MatIcon._prependPathToReferences()prepends the current pathname and search string to SVGsame-document references. A pathname beginning with
//is otherwise parsed as a protocol-relativeURL, which can turn
url(#id)into a cross-origin request.Google's OSS VRP referred this report to the Angular maintainers as issue
548479960.The local-only browser reproduction and evidence are available at
https://github.com/moamenmahmod/angular-material-funciri-poc.
Fixes #33811
Testing
pnpm test src/material/icon --no-watchpnpm lint