refactor(multiple): migrate tests to use whenStable#33317
Merged
Conversation
crisbeto
reviewed
May 29, 2026
| const click = async (target: HTMLElement) => { | ||
| target.dispatchEvent(new PointerEvent('click', {bubbles: true})); | ||
| fixture.detectChanges(); | ||
| await fixture.whenStable(); |
Member
There was a problem hiding this comment.
What's the context behind this change? I was under the impression that detectChanges is preferrable.
Member
Author
There was a problem hiding this comment.
For zoneless testbed it seems whenStable is preferred.
Some references:
Member
There was a problem hiding this comment.
Hmm interesting. IMO if the tests work as we expect, we don't need to change them, but I'm leaving it to your judgement.
Member
Author
There was a problem hiding this comment.
The migration idea came up only because recent experience of creating adev examples out of existing tests then got commented on the detectChanges usage. Agreed that it's not a necessary migration, it's more of a way to prevent the newer Aria tests to use detectChanges.
crisbeto
approved these changes
May 29, 2026
ok7sai
added
action: merge
Member
Author
ok7sai
added a commit
that referenced
this pull request
May 29, 2026
(cherry picked from commit 62547b3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.