Skip to content

AngularFire breaking change between 5.1.3 and 5.2.0 #2115

Closed

Description

@LanderBeeuwsaert

Hello,

This is an issue regarding a breaking change going from AngularFire 5.1.3 to 5.2.0 that I'm unsure that it is the intention.

See the closed issue here: firebase/firebase-js-sdk#1837 ; closed because of a request to re-open here.

Could of course be that this is intended behaviour but I wouldn't think so.

Activity

  1. N-Andronopoulos commented on Jun 27, 2019

    @N-Andronopoulos

    Same issue as me: #2124

  2. LanderBeeuwsaert commented on Jun 27, 2019

    @LanderBeeuwsaert
    Author

    Glad I'm not alone haha

  3. N-Andronopoulos commented on Jun 27, 2019

    @N-Andronopoulos

    Just turn off aot and you're good to go till its resolved.

    angular.json

    {
          "aot": false,
          ...
          "buildOptimizer": false,
    }
    
  4. LanderBeeuwsaert commented on Jun 27, 2019

    @LanderBeeuwsaert
    Author

    ok cool. Yeah thanks, but that would affect our production environment too much then. So not an option for us.

  5. matheo commented on Jul 13, 2019

    @matheo

    @jamesdaniels this issue got attention in the firebase-js-sdk repo, but here it remains without a solution :( I've spent most of my day today trying to figure out the build issue and I just got here...

    @LanderBeeuwsaert please rename this ticket to "Production Build Fail" or "Blank Screen of Death" so others can reach this easier, and figure that the only solution is to not optimize the bundle and get a ton of additional Mb in our bundle.

  6. jburson commented on Jul 15, 2019

    @jburson

    @jamesdaniels Version 5.2 should be rolled back unless a fix is coming very soon. This AOT bug is catastrophic and makes this version useless.

  7. matheo commented on Jul 16, 2019

    @matheo

    Refs #2117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions