fix(@ngtools/webpack): do not change user's LOCALE_ID#8604
Merged
Conversation
filipesilva
reviewed
Nov 22, 2017
| // This transform must go before replaceBootstrap because it looks for the entry module | ||
| // import, which will be replaced. | ||
| if (this._compilerOptions.i18nInLocale) { | ||
| if (this._compilerOptions._normalizedLocale) { |
Contributor
There was a problem hiding this comment.
Is _normalizedLocale a new option in AngularCompilerOptions?
Contributor
There was a problem hiding this comment.
Seems like he’s reading from the instance but setting in the options.
Contributor
There was a problem hiding this comment.
Surprised that this passes build.
Contributor
Author
There was a problem hiding this comment.
sorry, my mistake, fixing this!
ocombe
force-pushed
the
fix/locale_id-compiler
branch
from
392e9cd to
89b9ea3
Compare
hansl
approved these changes
Nov 22, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to normalize the locale to load i18n locale data files, but we should not change the actual user's locale that we pass to the compiler.
Fixes angular/angular#20340