feat(@angular/cli): support 5.0.0+ builds of @angular/service-worker#8080
Merged
Conversation
Member
Author
|
This will likely have issues on Windows until Angular 5.0.0-rc.3 is released, due to angular/angular@621f87b. |
Contributor
|
It throws an error when I don't have an ngsw.json file in |
e7ded45 to
4b2641a
Compare
Member
Author
|
I added an explicit error if the file is not found, @StephenFluin :) |
25da5be to
59a8136
Compare
|
we're on 5.0.0-rc.5, so this should work on Windows now. Hopefully this can be merged soon. |
1abfbb1 to
853c1ee
Compare
4741ca5 to
6ecd4d6
Compare
This was referenced Nov 2, 2017
hansl
approved these changes
Nov 6, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.