Repository navigation
Conversation
When an asset is replaced by renaming another file over it, as editors with atomic save do, the native file watcher on Linux reports the asset as added instead of modified. The incremental build only copied existing assets that were reported as modified, so the output kept the previous contents of the asset. Existing assets reported as added are now copied as well. The new spec disables polling so that the native watcher is used.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the application builder to correctly handle asset files replaced by a rename operation (such as an atomic save), which can be reported as added rather than modified by native file watchers. It also adds a corresponding integration test to verify this behavior. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an asset is replaced by renaming another file over it, as editors with atomic save do, the native file watcher on Linux reports the asset as added instead of modified. The incremental build only copied existing assets that were reported as modified, so the output kept the previous contents of the asset.
Existing assets reported as added are now copied as well. The new spec disables polling so that the native watcher is used.