fix(@angular/build): preserve custom config options in runnerConfig for vitest#33592
Open
clydin wants to merge 1 commit into
Open
fix(@angular/build): preserve custom config options in runnerConfig for vitest#33592clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
…or vitest Ensure optional Vitest configuration keys (such as `outputFile`, `cache`, and `testNamePattern`) are only defined on the inline options passed to `startVitest` if they are not `undefined`. This prevents Vitest's config merging from overriding user-defined custom configuration values in the runner configuration file with `undefined`.
1 task
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Vitest executor to conditionally include configuration options such as outputFile, cache, and testNamePattern. This ensures that user-defined configurations in vitest.config.ts are not inadvertently overridden by default values. Additionally, new test cases have been added to verify the preservation of custom reporter output files and coverage options. I have no further feedback to provide.
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure optional Vitest configuration keys (such as
outputFile,cache, andtestNamePattern) are only defined on the inline options passed tostartVitestif they are notundefined. This prevents Vitest's config merging from overriding user-defined custom configuration values in the runner configuration file withundefined.