fix(@angular/ssr): initialize the DI tokens with null to avoid requiring them to be set to optional#28799
Merged
Merged
Conversation
alan-agius4
added
the
action: review
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
add-tokens-option
branch
from
37cff9b to
c3b4bd5
Compare
…iring them to be set to optional This commit initializes the `REQUEST`, `RESPONSE_INIT`, and `REQUEST_CONTEXT` DI tokens with `null` values by default. Previously, these tokens lacked default values, which meant that developers had to explicitly mark them as optional when injecting them in constructors. This was necessary to avoid errors when these tokens were not provided, particularly in scenarios like client-side rendering or during development. By initializing these tokens with `null`, we eliminate the need for developers to mark them as optional, simplifying the code and improving the developer experience.
alan-agius4
force-pushed
the
add-tokens-option
branch
from
c3b4bd5 to
3f53493
Compare
dgp1130
approved these changes
Nov 6, 2024
alan-agius4
added
action: merge
Collaborator
Author
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit initializes the
REQUEST,RESPONSE_INIT, andREQUEST_CONTEXTDI tokens withnullvalues by default.Previously, these tokens lacked default values, which meant that developers had to explicitly mark them as optional when injecting them in constructors. This was necessary to avoid errors when these tokens were not provided, particularly in scenarios like client-side rendering or during development.
By initializing these tokens with
null, we eliminate the need for developers to mark them as optional, simplifying the code and improving the developer experience.