Make karma main file optional#23957
Merged
alan-agius4 merged 2 commits intoSep 27, 2022
Merged
Conversation
alan-agius4
added
state: blocked
target: major
angular-robot
Bot
added
the
feature
alan-agius4
force-pushed
the
make-karma-main-file-optional
branch
3 times, most recently
from
73f6a1e to
1b64266
Compare
alan-agius4
force-pushed
the
make-karma-main-file-optional
branch
4 times, most recently
from
2a3335d to
f1f1634
Compare
alan-agius4
added
the
action: review
clydin
approved these changes
Sep 27, 2022
Member
clydin
left a comment
clydin
left a comment
There was a problem hiding this comment.
LGTM.
Can you add the content of the internal test.ts file to one of the commit messages to improve the discoverability?
…ow optional The Karma builder `main` option is now optional. The default test bootstrapping is injected automatically in the bundle.
The test.ts is now included in `@angular-devkit/build-angular` and unless this needs to be customized is no longer needed to be provided.
Default config:
```js
// This file is required by karma.conf.js and loads recursively all the .spec and framework files
import { getTestBed } from '@angular/core/testing';
import {
BrowserDynamicTestingModule,
platformBrowserDynamicTesting
} from '@angular/platform-browser-dynamic/testing';
// First, initialize the Angular testing environment.
getTestBed().initTestEnvironment(BrowserDynamicTestingModule, platformBrowserDynamicTesting(), {
errorOnUnknownElements: true,
errorOnUnknownProperties: true
});
```
alan-agius4
force-pushed
the
make-karma-main-file-optional
branch
from
f1f1634 to
6c98b4a
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(@schematics/angular): remove test.ts file from new projects
The test.ts is now included in
@angular-devkit/build-angularand unless this needs to be customized is no longer needed to be provided.feat(@angular-devkit/build-angular): karma builder
mainoption is now optionalThe Karma builder
mainoption is now optional. The default test bootstrapping is injected automatically in the bundle.