Skip to content

Remove karma.conf.js from newly generated projects#23950

Merged
alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:make-karmaconfig-optional
Sep 28, 2022
Merged

Remove karma.conf.js from newly generated projects#23950
alan-agius4 merged 2 commits into
angular:mainfrom
alan-agius4:make-karmaconfig-optional

Conversation

@alan-agius4
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 commented Sep 23, 2022

feat(@schematics/angular): remove karma.conf.js from newly generated projects

@angular-devkit/build-angular now has a built in Karma config. Users can still create their own Karma configuration if they want to override the default configuration.

feat(@angular-devkit/build-angular): providing a karma config is now optional

Karma will now use a builtin config when the karmaConfig is not specified.

Comment thread packages/angular_devkit/build_angular/src/builders/karma/index.ts Outdated
@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Sep 23, 2022
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch from 66df6a0 to 2c31799 Compare September 23, 2022 13:40
@alan-agius4 alan-agius4 added this to the v15 Feature Freeze milestone Sep 23, 2022
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch 2 times, most recently from 13b636d to 08a6987 Compare September 23, 2022 14:31
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 23, 2022
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch 5 times, most recently from 1605558 to b5495f4 Compare September 23, 2022 17:52
@alan-agius4 alan-agius4 requested a review from clydin September 23, 2022 18:16
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 23, 2022
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch from b5495f4 to dbe7e51 Compare September 26, 2022 07:04
@angular-robot angular-robot Bot added the feature Label used to distinguish feature request from other issues label Sep 26, 2022
Comment thread packages/angular_devkit/build_angular/src/builders/karma/index.ts
Comment thread tests/legacy-cli/e2e_runner.ts
Comment thread tests/legacy-cli/e2e/utils/project.ts
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch from dbe7e51 to c9e3771 Compare September 26, 2022 15:52
@alan-agius4 alan-agius4 requested a review from clydin September 26, 2022 16:00
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch 6 times, most recently from 51564c1 to 54894d8 Compare September 28, 2022 07:05
…optional

Karma will now use a builtin config when the `karmaConfig` is not specified.
…d projects

`@angular-devkit/build-angular` now has a built in Karma config. Users can still create their own Karma configuration if they want to override the default configuration.
@alan-agius4 alan-agius4 force-pushed the make-karmaconfig-optional branch 2 times, most recently from 0965e6e to 9e01111 Compare September 28, 2022 09:32
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 28, 2022
@alan-agius4 alan-agius4 merged commit b6897db into angular:main Sep 28, 2022
@alan-agius4 alan-agius4 deleted the make-karmaconfig-optional branch September 28, 2022 15:37
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker feature Label used to distinguish feature request from other issues target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants