fix(@angular/cli): correctly handle --search option in ng doc#23164
Merged
Conversation
When the `--search` option is passed to `ng doc`, it should open a URL that does a search across the whole website (instead of the default behavior of limiting the search to API docs). Fix the `ng doc` command to implement the iteded behavior (previously, it did the opposite).
gkalpak
added
type: bug/fix
area: @angular/cli
action: review
alan-agius4
added
action: merge
Collaborator
|
@gkalpak, this doesn't apply cleanly on the patch branch. Hence I will change the target to rc. |
alan-agius4
added
target: rc
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
--searchoption is passed tong doc, it should open a URL that does a search across the whole website (instead of the default behavior of limiting the search to API docs).Fix the
ng doccommand to implement the iteded behavior (previously, it did the opposite).