feat(@schematics/angular): introduce addDependency rule to utilities#23067
Merged
Conversation
clydin
added
state: blocked
target: major
dgp1130
reviewed
May 2, 2022
clydin
force-pushed
the
schematics/utility/dependency
branch
3 times, most recently
from
63baf75 to
4fc986f
Compare
dgp1130
previously approved these changes
May 3, 2022
clydin
force-pushed
the
schematics/utility/dependency
branch
from
4fc986f to
d77bbc2
Compare
An `addDependency` schematics rule has been added to the newly introduced `utility` subpath export for the `@schematics/angular` package. This new rule allows for adding a package as a dependency to a `package.json`. By default the `package.json` located at the schematic's root will be used. The `packageJsonPath` option can be used to explicitly specify a `package.json` in a different location. The type of the dependency can also be specified instead of the default of the `dependencies` section by using the `type` option for either development or peer dependencies.
clydin
force-pushed
the
schematics/utility/dependency
branch
from
d77bbc2 to
c8434bb
Compare
dgp1130
approved these changes
May 3, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
addDependencyschematics rule has been added to the newly introducedutilitysubpath export for the@schematics/angularpackage.This new rule allows for adding a package as a dependency to a
package.json. By default thepackage.jsonlocatedat the schematic's root will be used. The
packageJsonPathoption can be used to explicitly specifya
package.jsonin different location. The type of the dependency can also be specified insteadof the default of the
dependenciessection by using thetypeoption for either development or peer dependencies.Will be added to the export path in #23041