build: lock file maintenance [er]#23001
Merged
Merged
Conversation
renovate
Bot
added
action: merge
renovate
Bot
force-pushed
the
renovate/lock-file-maintenance
branch
5 times, most recently
from
84e06ef to
979b498
Compare
renovate
Bot
force-pushed
the
renovate/lock-file-maintenance
branch
4 times, most recently
from
58e4944 to
5658beb
Compare
dgp1130
previously approved these changes
May 4, 2022
Collaborator
dgp1130
left a comment
dgp1130
left a comment
There was a problem hiding this comment.
Nit: Should the lockfile update commit come after the other commits? That way CI should pass at each of these commits if something got rolled back.
| copy[key] = deepCopy(valueCasted[key]); | ||
| } | ||
| valueCasted[copySymbol] = undefined; | ||
| delete valueCasted[copySymbol]; |
Collaborator
There was a problem hiding this comment.
Interesting, I was always unclear about the difference between delete and = undefined. Defined undefined properties strike again!
…operty after use The `deepCopy` utility function previously set its internal tracking symbol property to `undefined` after completion. However, this still caused the property to exist with a value of `undefined`. Jasmine 4.1 now checks for symbols with its `toEqual` expectation which resulted in failing tests. The internal tracking symbol property is now removed instead via `delete`.
clydin
force-pushed
the
renovate/lock-file-maintenance
branch
from
eae622f to
771f635
Compare
dgp1130
approved these changes
May 4, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
alan-agius4
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: "before 5am on monday" in timezone America/Tijuana.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by WhiteSource Renovate. View repository job log here.