feat(@schematcs/angular): change browserslist file name into .browserslistrc#17367
Merged
Conversation
alan-agius4
added
the
target: major
…erslistrc` Closes: #15961
clydin
approved these changes
Apr 2, 2020
| import { Path, join } from '@angular-devkit/core'; | ||
| import { DirEntry, Rule } from '@angular-devkit/schematics'; | ||
|
|
||
| function visit(directory: DirEntry): Path[] { |
Member
There was a problem hiding this comment.
nit: good use case for a generator
Collaborator
Author
There was a problem hiding this comment.
Indeed, it's a good use case. I updated the code to use a generator, can you please take a look?
If it's good to be merge please add the merge label. Thanks.
kara
pushed a commit
to angular/angular
that referenced
this pull request
Apr 8, 2020
In version 10, this file has been changed. See: angular/angular-cli#17367 PR Close #36504
This was referenced Apr 22, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #15961