feat(@angular-devkit/build-angular): default to NodeJS value for pres…#16648
Conversation
|
Not sure if this is the right place to put this config, let me know if there's a better place to set it. |
|
I’m ok with using it as a default. However, it would be a breaking change since the default would be different for some people. This could manifest in either broken builds or builds containing different dependencies than anticipated or expected. As a feature, this would probably fall into the v10 timeframe. |
e3699cb to
f5d55dd
Compare
|
@clydin Sounds good to me, how would we make sure to come back and check this when there's a v10 branch? |
|
@Toxicable, I can create a v10 milestone and assign this Pr to it. |
826bdc6 to
6105bf4
Compare
6105bf4 to
3282882
Compare
3282882 to
611a57c
Compare
alan-agius4
left a comment
There was a problem hiding this comment.
Thanks Fabian! LGTM.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…erveSymlinks
Under bazel
preserveSymlinkswould have to be set in two different places, this makes it so it only has to be set once by using the value from NodeJS if it's set.