Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP output wraps SQL tokens in double-quoted strings but leaves literal
$characters unescaped. SQL text such asSELECT '$name'or PostgreSQL dollar-quoted strings is therefore interpreted as PHP variable interpolation instead of retaining its original value. PHP string rules require\$for a literal dollar sign.Escape dollars after the existing backslash/quote escaping. Regression tests cover SQL string literals, dollar quoting, identifiers, comments and an existing backslash before a dollar. The generated PHP assignment variable remains unchanged.
Validation: all five regressions fail before the fix. The full suite passes after it (511 passed, 2 expected failures, 1 existing unexpected pass); Ruff passes.