Repository navigation
Conversation
Author
|
On the tooling, since it is reasonable to ask where the test came from: the The same run turned up a few other survivors in Same seed plants the same faults, so you will see exactly what I saw. Would genuinely value feedback from anyone maintaining a suite this size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest) — 506 passed, 2 xfailed, 1 xpassedruff check sqlparse/passes; no source files touched)TestFormatReindent.test_optionchecks that an invalid value raisesSQLParseErrorforreindent,indent_tabs,indent_width,wrap_afterand
comma_first. Two options validated the same way informatter.pyaremissing from it:
reindent_alignedandindent_after_first. The latter doesnot appear anywhere in the suite.
Both already raise correctly, so this adds no behaviour, only the coverage.
How I noticed: deleting the
raiseatsqlparse/formatter.py:83leaves theentire suite green (505 passed). With these two lines it fails.
I found that by planting small faults in the source and seeing which ones the
suite did not catch.