docs(ack-pay): align receipt API examples#89
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
WalkthroughThis pull request updates documentation for the ACK receipt payment verification feature. The credential type example is changed from ChangesACK Receipt Verification Documentation
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
trustedReceiptIssuers, matching the exportedverifyPaymentReceiptoptionsisPaymentReceiptClaimand import the exported receipt credential guardPaymentReceiptCredentialWhy
The README currently shows
trustedIssuers, butverifyPaymentReceiptacceptstrustedReceiptIssuers. It also referencesisPaymentReceiptClaim, which is internal toreceipt-claim-verifier.tsand is not exported from@agentcommercekit/ack-pay.Verification
corepack pnpm install --frozen-lockfilecorepack pnpm check:formatgit diff --checkcorepack pnpm --filter @agentcommercekit/ack-pay check:typesinitially failed because workspace package exports resolve from builtdistoutputscorepack pnpm --filter @agentcommercekit/ack-pay... buildcorepack pnpm --filter @agentcommercekit/ack-pay check:typesNotes
This is docs-only and avoids the receipt verification logic changed in #88.
AI Usage Disclosure
This contribution was AI-assisted using Codex CLI and the Codex app. AI assistance was used for repository/docs navigation, understanding ACK/Catena context, identifying relevant issues or contribution areas, and assisting with small edits/validation. I reviewed the final diff and take responsibility for the submitted changes.
Summary by CodeRabbit
Documentation
PaymentReceiptCredential) and trust configuration patterns withtrustedReceiptIssuers