fix(docs): replace broken demo video links in identity and payments READMEs#106
Conversation
WalkthroughThis PR updates two demo README files by replacing previous video references with embedded, centered YouTube player links. Both the identity and payments demo READMEs now display clickable YouTube thumbnail embeds in their respective "Demo Video" sections using HTML ChangesDemo Video Documentation Updates
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
venables
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing these broken demo video links, @alelpoan! 🙏
I ran a multi-agent panel review on this change and all reviewers came back clean:
- Both
maxresdefault.jpgthumbnails return HTTP 200, so this doesn't reintroduce the 404s it fixes. - The videos are public and correctly paired (
CDJ8pm_KlOw→ ACK-ID Demo indemos/identity,49VaG1-u1i0→ ACK-Pay Demo indemos/payments— no swap). - The centered
<p>/<a>/<img>markup is GitHub-Markdown-supported.
Clean, well-scoped docs fix. Approving and merging — thank you for the contribution!
Thanks for the thorough review and merging so quickly. Glad it was helpful. 🙏 |
Fix broken demo video links in identity and payments READMEs.
Both README files referenced
github.com/user-attachments/assets/...video links that return 404. Replaced with clickable YouTube preview thumbnails linking to the correct videos already used on the official docs site at agentcommercekit.com.Note: GitHub Markdown does not support
<iframe>embeds, so a clickable thumbnail image is the standard approach for linking to videos in READMEs.Changes:
demos/identity/README.md: broken
user-attachmentsasset link →YouTube thumbnail preview for
https://www.youtube.com/watch?v=CDJ8pm_KlOwdemos/payments/README.md: broken
user-attachmentsasset link →YouTube thumbnail preview for
https://www.youtube.com/watch?v=49VaG1-u1i0Test plan:
Documentation-only change; no code paths affected.
Summary by CodeRabbit
Closes #107
Screenshots
Before (broken 404 video):
After (clickable YouTube preview):
Screenshots
Before (broken 404 video):
After (clickable YouTube preview):