Skip to content

fix(docs): replace broken demo video links in identity and payments READMEs#106

Merged
venables merged 2 commits into
agentcommercekit:mainfrom
alelpoan:fix/broken-demo-video-links
Jun 4, 2026
Merged

fix(docs): replace broken demo video links in identity and payments READMEs#106
venables merged 2 commits into
agentcommercekit:mainfrom
alelpoan:fix/broken-demo-video-links

Conversation

@alelpoan
Copy link
Copy Markdown
Contributor

@alelpoan alelpoan commented Jun 1, 2026

Fix broken demo video links in identity and payments READMEs.

Both README files referenced github.com/user-attachments/assets/...video links that return 404. Replaced with clickable YouTube preview thumbnails linking to the correct videos already used on the official docs site at agentcommercekit.com.

Note: GitHub Markdown does not support <iframe> embeds, so a clickable thumbnail image is the standard approach for linking to videos in READMEs.

Changes:
demos/identity/README.md: broken user-attachments asset link →
YouTube thumbnail preview for https://www.youtube.com/watch?v=CDJ8pm_KlOw
demos/payments/README.md: broken user-attachments asset link →
YouTube thumbnail preview for https://www.youtube.com/watch?v=49VaG1-u1i0

Test plan:
Documentation-only change; no code paths affected.

Summary by CodeRabbit

  • Documentation
    • Embedded YouTube demo videos directly in the identity and payments demo guides, replacing previous media references for improved accessibility and streamlined user experience when reviewing demo content.

Closes #107

Screenshots

Before (broken 404 video):

image

After (clickable YouTube preview):

image

Screenshots

Before (broken 404 video):

image

After (clickable YouTube preview):

image

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 1, 2026

Review Change Stack

Walkthrough

This PR updates two demo README files by replacing previous video references with embedded, centered YouTube player links. Both the identity and payments demo READMEs now display clickable YouTube thumbnail embeds in their respective "Demo Video" sections using HTML <p align="center"> blocks.

Changes

Demo Video Documentation Updates

Layer / File(s) Summary
YouTube embedded video documentation
demos/identity/README.md, demos/payments/README.md
Identity and payments demo READMEs update "Demo Video" sections by replacing previous media/attachment references with centered HTML <p align="center"> blocks containing YouTube video links and thumbnails.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing broken demo video links in two README files (identity and payments) with working YouTube thumbnails.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@venables venables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing these broken demo video links, @alelpoan! 🙏

I ran a multi-agent panel review on this change and all reviewers came back clean:

  • Both maxresdefault.jpg thumbnails return HTTP 200, so this doesn't reintroduce the 404s it fixes.
  • The videos are public and correctly paired (CDJ8pm_KlOw → ACK-ID Demo in demos/identity, 49VaG1-u1i0 → ACK-Pay Demo in demos/payments — no swap).
  • The centered <p>/<a>/<img> markup is GitHub-Markdown-supported.

Clean, well-scoped docs fix. Approving and merging — thank you for the contribution!

@venables venables merged commit f69d76a into agentcommercekit:main Jun 4, 2026
1 check passed
@alelpoan
Copy link
Copy Markdown
Contributor Author

alelpoan commented Jun 4, 2026

Thanks for catching and fixing these broken demo video links, @alelpoan! 🙏

I ran a multi-agent panel review on this change and all reviewers came back clean:

  • Both maxresdefault.jpg thumbnails return HTTP 200, so this doesn't reintroduce the 404s it fixes.
  • The videos are public and correctly paired (CDJ8pm_KlOw → ACK-ID Demo in demos/identity, 49VaG1-u1i0 → ACK-Pay Demo in demos/payments — no swap).
  • The centered <p>/<a>/<img> markup is GitHub-Markdown-supported.

Clean, well-scoped docs fix. Approving and merging — thank you for the contribution!

Thanks for the thorough review and merging so quickly. Glad it was helpful. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(docs): broken demo video links in identity and payments READMEs

2 participants