Propagate (atespace/actor_id) to atelet.#373
Merged
Merged
Conversation
Julian Gutierrez Oschmann (juli4n)
requested review from
Haven Xia (HavenXia) and
Tim Hockin (thockin)
Collaborator
There was a problem hiding this comment.
Adding actor_atespace to log labels LGTM — logs are the right layer for per-atespace attribution.
But could we keep actor_template_name (actor_template_namespace can be removed) on the log labels in addition, rather than replacing them?
"Show my logs from all actors of template X" is a real debugging workflow IMO, and since one atespace can run actors from many templates, atespace itself can't answer it.
Collaborator
Author
There was a problem hiding this comment.
Done.
|
|
||
| #### 2. Template-Centric View | ||
| To monitor or debug all actor instances created from a specific template (e.g., analyzing the collective behavior or error rates of all counter actors): | ||
| #### 2. Atespace-Centric View |
Collaborator
There was a problem hiding this comment.
Same to my another comment.
Collaborator
Author
There was a problem hiding this comment.
Done.
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
atelet_api
branch
2 times, most recently
from
c891dfe to
fa5b164
Compare
This fixes an issue where atelet/ateom will clash the state of actors with same ID within different atespaces. Once substrate resources get UIDs, we should revisit the way atelet / ateom does the bookkeeping and check in which cases it should use UID instead of (atespace,actor_id).
Julian Gutierrez Oschmann (juli4n)
force-pushed
the
atelet_api
branch
from
fa5b164 to
a5d30aa
Compare
Haven Xia (HavenXia)
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where atelet/ateom will clash the state of actors with same ID within different atespaces.
Once substrate resources get UIDs, we should revisit the way atelet / ateom does the bookkeeping and check in which cases it should use UID instead of (atespace,actor_id).