Add update/verify for go-generate#2
Merged
Benjamin Elder (BenTheElder) merged 1 commit intoMay 20, 2026
Merged
Conversation
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
Can we remove go generate from the install script now?
Collaborator
Author
|
Can do! |
Tim Hockin (thockin)
force-pushed
the
hack-update-go-generate
branch
from
d1f07fa to
1c281ca
Compare
Collaborator
Author
|
done |
Benjamin Elder (BenTheElder)
approved these changes
May 20, 2026
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Collaborator
Author
|
I got the first test flake too! |
Collaborator
Author
|
As per COLLABORATING.md - the reviewer merges. |
Benjamin Elder (BenTheElder)
merged commit bbf8013
into
agent-substrate:main
5 of 6 checks passed
2 tasks
Collaborator
Should be fixed by #6 |
Julian Gutierrez Oschmann (juli4n)
pushed a commit
that referenced
this pull request
May 20, 2026
- Add a trivial /readyz handler (which will only be served once we finish initializing) - We use the metrics handler because we already expose an HTTP port there and there should be no conflict - Add a readiness probe to the install manifest - Update install script to wait for readiness on core components Improves reliability for the demo flow, including the test flake seen in #2 > It's a good idea to open an issue first for discussion. - [x] Tests pass - [x] Appropriate changes to documentation are included in the PR
Benjamin Elder (BenTheElder)
added
the
kind/bug
han2ni3bal-pixel
pushed a commit
to han2ni3bal-pixel/substrate
that referenced
this pull request
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update generated code.