Skip to content

fix: support UUIDs as per RFC spec (#50) - #53

Merged
thetutlage merged 2 commits into
adonisjs:developfrom
aikrom:develop
Feb 25, 2022
Merged

thetutlage merged 2 commits into
adonisjs:developfrom
aikrom:develop

Conversation

@aikrom

@aikrom aikrom commented Feb 9, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Added support uppercase/lowercase UUIDs as per RFC spec.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Comment thread src/Router/Matchers.ts
@thetutlage

Copy link
Copy Markdown
Member

Thanks! Finally, let's have a test that validates case insensitive uuid and casts it to lower

@thetutlage

Copy link
Copy Markdown
Member

Merging, as I am already working on a release. I will add the required tests myself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants