fix: clone functionality to include submodules#1413
Conversation
|
This PR will trigger a patch release when merged. |
rpapani
left a comment
rpapani
left a comment
There was a problem hiding this comment.
Thank you @dmaurya929
A few things to consider
- We've set the ephemeral storage to 3GB, for these 15% customers, did you know the rough size of all the modules, if it fits under 1-1.5GB, we are good, otherwise, we may need to increase this.
- Will the submodules exist in the same repo or external repos? If external repos, we need to know the co-ordinates of those repos, creds etc in the case of standard repos. This may need update to our code object schema to accept multiple repo details
- can you share an example customer program/repo so that I can try this on my side and see if there's any gap
…po origin - Changed the construction of the git command's authentication header for standard repositories to use the repo origin instead of the full URL. This ensures the header is applied to all paths on the host, including submodule URLs. - Updated related test cases to reflect the new header format.
| const repoOrigin = `${new URL(repoUrl).origin}/`; | ||
| return [ | ||
| '-c', `http.${repoUrl}.extraheader=Authorization: Basic ${basicAuth}`, | ||
| '-c', `http.${repoOrigin}.extraheader=Authorization: Basic ${basicAuth}`, |
There was a problem hiding this comment.
using the origin could be security threat especially with standard repos, so we should reduce this to customer name, like https://git.cloudmanager.adobe.com/{customer_name}/, that way we'll scope to obtaining only that customer code.
There was a problem hiding this comment.
sure, anyway tokens are tenant specific I think
|
@dmaurya929 I've created https://jira.corp.adobe.com/browse/SITES-43089 for handling the import on mysticat and autofix as well |
Below is the few customer with submodule
For a few customers, the zip size with submodules is 1 - 1.5 GB. I'll let you know if I see > 2 GB. |
yes, atleast till now I have seen the same org |
2 participants
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!