Skip to content

fix conditional useHref call#7032

Merged
LFDanLu merged 3 commits into
adobe:mainfrom
abeljohn:fix-conditional-usehref-call
Sep 19, 2024
Merged

fix conditional useHref call#7032
LFDanLu merged 3 commits into
adobe:mainfrom
abeljohn:fix-conditional-usehref-call

Conversation

@abeljohn

Copy link
Copy Markdown
Contributor

Closes #7028

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@snowystinger snowystinger left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for opening a PR and starting to look at what makes sense for the types

You'll need to sign the CLA https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement then you may need to close and reopen the PR to get it to take hold.

@abeljohn

Copy link
Copy Markdown
Contributor Author

Thanks @snowystinger , should be good to go now!

@LFDanLu LFDanLu merged commit 097c8fc into adobe:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rules of hooks error in useLinkProps

3 participants