fix conditional useHref call#7032
Merged
Merged
Conversation
snowystinger
left a comment
Member
There was a problem hiding this comment.
thanks for opening a PR and starting to look at what makes sense for the types
You'll need to sign the CLA https://react-spectrum.adobe.com/contribute.html#contributor-license-agreement then you may need to close and reopen the PR to get it to take hold.
Contributor
Author
|
Thanks @snowystinger , should be good to go now! |
snowystinger
approved these changes
Sep 17, 2024
LFDanLu
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7028
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: