fix: TokenField RTL, IME composition, and range selection#10273
Merged
Conversation
# Conflicts: # packages/react-aria/src/interactions/createEventHandler.ts
this fixes autocomplete
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
## API Changes
react-aria-components/react-aria-components:Provider-Provider <A, B, C, D, E, F, G, H, I, J, K, L> {
+Provider <A, B, C, D, E, F, G, H, I, J, K, L, M> {
children: ReactNode
- values: ProviderValues<A, B, C, D, E, F, G, H, I, J, K, L>
+ values: ProviderValues<A, B, C, D, E, F, G, H, I, J, K, L, M>
}@react-spectrum/ai/@react-spectrum/ai:TokenSegmentList-TokenSegmentList {
+TokenSegmentList <T = any> {
caretPosition: Position
- constructor: (readonly Array<TokenFieldSegment>, TokenSegmentListOptions) => void
- delete: (Position, Intl.Segmenter, any, any) => TokenSegmentList
- deleteLine: (Position, any, any) => TokenSegmentList
+ constructor: (readonly Array<TokenFieldSegment<T>>, TokenSegmentListOptions) => void
+ delete: (Position, Intl.Segmenter, any, any) => this
+ deleteLine: (Position, any, any) => this
endCoalescing: () => void
findBoundaryWithSegmenter: (Position, Intl.Segmenter, any) => Position | null
findLineBoundary: (Position, any) => Position | null
findText: (Position, any, string | RegExp) => Position | null
- insertToken: (Position) => TokenSegmentList
- redo: () => TokenSegmentList
- replaceRange: (Position, Position, string, any) => TokenSegmentList
- replaceRangeWithSegments: (Position, Position, Array<TokenFieldSegment>, any) => TokenSegmentList
- segments: readonly Array<TokenFieldSegment>
- slice: (Position, Position) => TokenSegmentList
+ redo: () => this
+ replaceRange: (Position, Position, string, any) => this
+ replaceRangeWithSegments: (Position, Position, Array<TokenFieldSegment<T>>, any) => this
+ segments: readonly Array<TokenFieldSegment<T>>
+ slice: (Position, Position) => this
toString: () => string
- undo: () => TokenSegmentList
- withCaretPosition: (Position) => TokenSegmentList
+ undo: () => this
+ withCaretPosition: (Position) => this
} |
snowystinger
approved these changes
Jul 6, 2026
snowystinger
left a comment
Member
There was a problem hiding this comment.
lets get it in for testing because that is a lot
LFDanLu
approved these changes
Jul 6, 2026
LFDanLu
left a comment
Member
There was a problem hiding this comment.
Seems to work pretty well on my android device, and desktop IME seems to works as well. Would be nice if there were Arabic/Hebrew search results we could test against (I know you have tests for these but just in case).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes many TokenField bugs found during testing.
isDisabled,isReadOnly, andmultiline(prop to be renamed)any