feat(examples): support @adcp/sdk 7.10 storyboards#783
Draft
sangilish wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #782.
This moves the example storyboard jobs to
@adcp/sdk@7.10.1and catches the multi-platform seller example up to the stricter 7.10 storyboard checks.What changed
ADCP_SDK_VERSION: "7.10.1"workflow pin and versioned npm cache keys for all storyboard jobs.list_accountssupport to the multi-platform demo account store so sales specialisms advertise an account-discovery tool.format_id, honorlist_creativescreative-id filters, and returnNOT_CANCELLABLEfor repeated cancellation.Testing
uv run pytest tests/ -q— 4943 passed, 34 skipped, 9 deselected, 1 xfaileduv run ruff check examples/multi_platform_seller/src/account_store.py examples/multi_platform_seller/src/mock_guaranteed.py examples/multi_platform_seller/src/mock_non_guaranteed.py tests/test_multi_platform_seller_example.pyuv run mypy src/adcp/adcp storyboard run http://127.0.0.1:3001/mcp media_buy_seller --json --allow-httpwith@adcp/sdk@7.10.1— passing, 57 passed / 0 failedadcp storyboard run http://tenant-a.localhost:3001/mcp media_buy_seller --json --allow-httpwith@adcp/sdk@7.10.1— passing, 31 passed / 0 failedadcp storyboard run http://tenant-b.localhost:3001/mcp media_buy_seller --json --allow-httpwith@adcp/sdk@7.10.1— passing, 31 passed / 0 failedadcp storyboard run http://127.0.0.1:3003/mcp media_buy_seller/proposal_finalize --json --allow-httpwith@adcp/sdk@7.10.1— passing, 5 passed / 0 failedadcp storyboard run http://acme.localhost:3001/mcp media_buy_seller --auth dev-bearer-token-acme-1 --json --allow-httpwith@adcp/sdk@7.10.1and local Postgres/mock-server — passing, 32 passed / 0 failed; upstream traffic total 44Draft until GitHub Actions confirms the full matrix.