feat(testing): make SellerA2AClient event drain configurable#763
feat(testing): make SellerA2AClient event drain configurable#763sangilish wants to merge 2 commits into
Conversation
IPR Policy Agreement Required@sangilish — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement. To agree, post a new comment on this PR with the exact phrase: Your signature is recorded once and covers all contributions to AAO repositories. See |
|
I have read the IPR Policy |
IPR Policy — signedThanks, @sangilish. Your agreement to the IPR Policy is recorded at |
|
I have read the IPR Policy |
|
Thanks, @sangilish — IPR acknowledgment noted. Generated by Claude Code |
|
Thanks @sangilish — IPR acknowledgment noted. Generated by Claude Code |
|
This is ready for review now. CI is green, and I kept the change scoped to #698 with the default behavior preserved. |
|
Acknowledged — thanks for the heads-up. Noted that CI is green, default cap is preserved, and scope is limited to #698. No action needed from this routine; the PR is queued for human review. Generated by Claude Code |
bokelley
left a comment
There was a problem hiding this comment.
Looks good. Updated against main and rechecked the touched A2A harness surfaces locally.
|
Superseded by #829, which merged the same patch from a base-repo branch so the required CodeQL check could run. Thanks again @sangilish. |
Pull request was closed
Summary
Refs #698.
This makes the A2A seller test harness event-drain budget configurable.
SellerA2AClient.invoke()now accepts a keyword-onlymax_eventsargument that defaults to the existing hard cap of 32, so current callers keep the same behavior while tests for noisier A2A flows can opt into a larger drain budget.What changed
max_events: int = 32toSellerA2AClient.invoke().timeout_secondsandmax_events.Testing
Passed:
uv run python -m pytest tests/test_seller_a2a_client.py -quv run ruff check src/adcp/testing/harness.py tests/test_seller_a2a_client.pyuv run mypy src/adcp/testing tests/test_seller_a2a_client.pyuv run python -m pytest -qAttempted broader checks:
uv run ruff checkfails on pre-existing unrelated lint issues outside this PR's files (26 errors reported).uv run mypy src testsfails on pre-existing unrelated type issues outside this PR's files (1688 errors in 160 files reported).