Skip to content

fix(ci): align pre-commit mypy with CI — install mypy in uv dev group #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 2 commits into from
May 3, 2026
Merged

fix(ci): align pre-commit mypy with CI — install mypy in uv dev group #427

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14624db
fix(ci): align pre-commit mypy with CI — install mypy in uv dev group
bokelley May 3, 2026
6be7831
fix(ci): pin mypy version range in optional-deps to match dev group
bokelley May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ dev = [
"pytest>=7.0.0",
"pytest-asyncio>=0.21.0",
"pytest-cov>=4.0.0",
"mypy>=1.0.0",
"mypy>=1.20.0,<1.21",
"black>=23.0.0",
"ruff>=0.1.0",
# Pin to exact version: codegen's variant numbering (e.g. CreateMediaBuyResponse1 vs
Expand Down Expand Up @@ -238,4 +238,12 @@ dev = [
"datamodel-code-generator==0.56.1",
"pre-commit>=4.4.0",
"types-protobuf>=7.34.1.20260408",
# Pinned in the dev group so ``uv run mypy`` (used by the pre-commit
# hook) installs mypy into the project venv instead of falling
# through to whatever ``mypy`` happens to be on $PATH (e.g. a
# homebrew install). Without this, pre-commit's mypy version drifts
# from CI's, producing a different error count than CI on the same
# source — and a dead-weight hook that everyone bypasses with
# ``SKIP=mypy``.
"mypy>=1.20.0",
]
Loading